C++核心準則?NR.5：不要使用兩階段初始化

NR.5: Don't use two-phase initialization

NR.5：不要使用兩階段初始化

Reason（原因）

Splitting initialization into two leads to weaker invariants, more complicated code (having to deal with semi-constructed objects), and errors (when we didn't deal correctly with semi-constructed objects consistently).

將初始化分為兩部分會導致不變性較弱，代碼更復雜（必須處理半結構化對象）和錯誤（當我們不能始終如一地正確處理半結構化對象時）。

Example, bad（反面示例）

// Old conventional style: many problems

class Picture
{
    int mx;
    int my;
    char * data;
public:
    // main problem: constructor does not fully construct
    Picture(int x, int y)
    {
        mx = x;         // also bad: assignment in constructor body
                        // rather than in member initializer
        my = y;
        data = nullptr; // also bad: constant initialization in constructor
                        // rather than in member initializer
    }

    ~Picture()
    {
        Cleanup();
    }

    // ...

    // bad: two-phase initialization
    bool Init()
    {
        // invariant checks
        if (mx <= 0 || my <= 0) {
            return false;
        }
        if (data) {
            return false;
        }
        data = (char*) malloc(mx*my*sizeof(int));   // also bad: owning raw * and malloc
        return data != nullptr;
    }

    // also bad: no reason to make cleanup a separate function
    void Cleanup()
    {
        if (data) free(data);
        data = nullptr;
    }
};

Picture picture(100, 0); // not ready-to-use picture here
// this will fail..
if (!picture.Init()) {
    puts("Error, invalid picture");
}
// now have a invalid picture object instance.

Example, good（范例）

class Picture
{
    int mx;
    int my;
    vector data;

    static int check_size(int size)
    {
        // invariant check
        Expects(size > 0);
        return size;
    }

public:
    // even better would be a class for a 2D Size as one single parameter
    Picture(int x, int y)
        : mx(check_size(x))
        , my(check_size(y))
        // now we know x and y have a valid size
        , data(mx * my * sizeof(int)) // will throw std::bad_alloc on error
    {
        // picture is ready-to-use
    }

    // compiler generated dtor does the job. (also see C.21)

    // ...
};

Picture picture1(100, 100);
// picture is ready-to-use here...

// not a valid size for y,
// default contract violation behavior will call std::terminate then
Picture picture2(100, 0);
// not reach here...

Alternative（代替選項）

• Always establish a class invariant in a constructor.

  始終在構造函數(shù)中建立類不變式。
  

• Don't define an object before it is needed.

  不要在需要之前定義對象。
  

  
  

原文鏈接

https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#nr5-dont-use-two-phase-initialization

新書介紹

《實戰(zhàn)Python設計模式》是作者最近出版的新書，拜托多多關注！

本書利用Python 的標準GUI 工具包tkinter，通過可執(zhí)行的示例對23 個設計模式逐個進行說明。這樣一方面可以使讀者了解真實的軟件開發(fā)工作中每個設計模式的運用場景和想要解決的問題；另一方面通過對這些問題的解決過程進行說明，讓讀者明白在編寫代碼時如何判斷使用設計模式的利弊，并合理運用設計模式。

對設計模式感興趣而且希望隨學隨用的讀者通過本書可以快速跨越從理解到運用的門檻；希望學習Python GUI 編程的讀者可以將本書中的示例作為設計和開發(fā)的參考；使用Python 語言進行圖像分析、數(shù)據(jù)處理工作的讀者可以直接以本書中的示例為基礎，迅速構建自己的系統(tǒng)架構。

覺得本文有幫助？請分享給更多人。

關注微信公眾號【面向對象思考】輕松學習每一天！

面向對象開發(fā)，面向對象思考！